Add literal contains filters across source queries and analysis context
This commit is contained in:
@@ -34,6 +34,15 @@ def coverage_comparison():
|
||||
|
||||
|
||||
class BoundReportTest(unittest.TestCase):
|
||||
def test_scope_label_distinguishes_full_value_from_substring_filters(self):
|
||||
from nao_evidence_report import _scope_label
|
||||
label = _scope_label({'columnFilters': [
|
||||
{'field': 'orderNo', 'stages': ['black'], 'operator': 'in', 'values': ['WO-7']},
|
||||
{'field': 'orderNo', 'stages': ['bright'], 'operator': 'contains', 'values': ['07']},
|
||||
]})
|
||||
self.assertIn('黑片来源字段为WO-7', label)
|
||||
self.assertIn('亮片来源字段包含片段07', label)
|
||||
|
||||
def test_priority_summary_keeps_three_signals_and_rate_denominators_separate(self):
|
||||
signals={'scrapIncrease':[{'label':'放量规格','scrapDelta':120}],
|
||||
'currentScrap':[{'label':'存量规格','current':{'scrapWeight':500}}],
|
||||
|
||||
@@ -456,9 +456,11 @@ class HistoryReportExecutionTest(unittest.TestCase):
|
||||
first_section = candidate['sections'][0]
|
||||
first_section['filters']['columnFilters'] = [{
|
||||
'field': 'src_work_order', 'stages': ['black'], 'operator': 'in', 'values': ['WO-7'],
|
||||
}, {
|
||||
'field': 'src_contains_code', 'stages': ['bright'], 'operator': 'contains', 'values': ['07'],
|
||||
}]
|
||||
set_source_task_context(candidate, SOURCE_A,
|
||||
{'sourceFieldLabels': {'src_work_order': '黑片委托单号'}})
|
||||
{'sourceFieldLabels': {'src_work_order': '黑片委托单号', 'src_contains_code': '客户代码'}})
|
||||
set_source_task_context(candidate, SOURCE_B,
|
||||
{'sourceFieldLabels': {'src_work_order': '亮片委托单号'}})
|
||||
fact = candidate['facts'][0]
|
||||
@@ -476,12 +478,14 @@ class HistoryReportExecutionTest(unittest.TestCase):
|
||||
projected = _history_model_fact_projection(candidate, [fact])[0]
|
||||
self.assertIn('产业部 消费电子产业部', projected['modelScope']['displayScope'])
|
||||
self.assertIn('业务分组 消费电子-3C', projected['modelScope']['displayScope'])
|
||||
self.assertIn('黑片委托单号 包含 WO-7', projected['modelScope']['displayScope'])
|
||||
self.assertIn('黑片委托单号 为 WO-7', projected['modelScope']['displayScope'])
|
||||
self.assertIn('亮片 客户代码 包含片段 07', projected['modelScope']['displayScope'])
|
||||
self.assertIn('消费电子产业部', projected['modelText'])
|
||||
self.assertIn('消费电子-3C', projected['modelText'])
|
||||
self.assertIn('黑片委托单号', projected['modelText'])
|
||||
self.assertIn('WO-7', projected['modelText'])
|
||||
for machine_label in ('筛选 {', 'group:', 'department:', 'columnFilters:', 'src_work_order'):
|
||||
for machine_label in ('筛选 {', 'group:', 'department:', 'columnFilters:',
|
||||
'src_work_order', 'src_contains_code'):
|
||||
self.assertNotIn(machine_label, projected['modelText'])
|
||||
self.assertNotIn(machine_label, json.dumps(projected['modelScope'], ensure_ascii=False))
|
||||
self.assertEqual(projected['text'], source_text)
|
||||
@@ -581,7 +585,7 @@ class HistoryReportExecutionTest(unittest.TestCase):
|
||||
goals = payload['historySourceGoals']
|
||||
self.assertTrue(any('产业部 消费电子产业部' in goal['displayScopeLabel']
|
||||
and '业务分组 消费电子-3C' in goal['displayScopeLabel']
|
||||
and '黑片委托单号 包含 WO-7' in goal['displayScopeLabel']
|
||||
and '黑片委托单号 为 WO-7' in goal['displayScopeLabel']
|
||||
for goal in goals))
|
||||
self.assertTrue(all('filters' not in goal and '_sourceTurnId' not in goal for goal in goals))
|
||||
self.assertTrue(all('filters' not in scope and 'sourceTurnId' not in scope
|
||||
|
||||
@@ -284,6 +284,10 @@ class QualityToolsTests(unittest.TestCase):
|
||||
self.assertEqual(definition["inputSchema"]["properties"]["mode"]["enum"],
|
||||
["catalog", "query", "rank", "compare", "top", "changes", "defects", "details", "investigate"])
|
||||
self.assertIn("defect", definition["inputSchema"]["properties"])
|
||||
column_filter = definition["inputSchema"]["properties"]["columnFilters"]
|
||||
self.assertEqual(column_filter["items"]["properties"]["operator"]["enum"],
|
||||
["in", "not_in", "contains", "is_empty", "not_empty"])
|
||||
self.assertIn("MySQL LOCATE", column_filter["description"])
|
||||
self.assertFalse(definition["inputSchema"]["additionalProperties"])
|
||||
self.assertEqual(definition["inputSchema"]["allOf"][0]["then"]["required"], ["releaseId"])
|
||||
|
||||
@@ -529,11 +533,11 @@ class QualityToolsTests(unittest.TestCase):
|
||||
if path == "/api/analysis/tools/catalog":
|
||||
response["sourceFields"] = [{"key": "customerCode", "label": "客户代码",
|
||||
"type": "source_value", "stages": ["black"],
|
||||
"columns": {"black": "customer_code"}, "operators": ["in"]}]
|
||||
"columns": {"black": "customer_code"}, "operators": ["in", "contains"]}]
|
||||
return response
|
||||
api = AuthorizedColumnApi()
|
||||
tools = QualityTools(api_factory=lambda: api, evidence_dir=self.temp.name)
|
||||
rule = {"field": "customerCode", "stages": ["black"], "operator": "in", "values": ["C-17"]}
|
||||
rule = {"field": "customerCode", "stages": ["black"], "operator": "contains", "values": ["C-17"]}
|
||||
result = tools.quality_data({"mode": "defects", "releaseId": RELEASE,
|
||||
"period": {"year": 2026, "monthStart": 3, "monthEnd": 9},
|
||||
"filters": {"exclusions": {"product": ["规格甲"]}}, "columnFilters": [rule],
|
||||
|
||||
@@ -25,7 +25,7 @@ from test_nao_quality_tools import FakeApi, RELEASE
|
||||
def source_field(key, label, black, bright, stages=('black', 'bright')):
|
||||
return {'key': key, 'label': label, 'columns': {'black': black, 'bright': bright},
|
||||
'stages': list(stages), 'type': 'source_value',
|
||||
'operators': ['in', 'not_in', 'is_empty', 'not_empty']}
|
||||
'operators': ['in', 'not_in', 'contains', 'is_empty', 'not_empty']}
|
||||
|
||||
|
||||
SOURCE_FIELDS = [
|
||||
@@ -349,6 +349,15 @@ class SourceColumnProtocolTests(unittest.TestCase):
|
||||
with self.assertRaisesRegex(TaskUnavailable, '不超过256字符'):
|
||||
protocol_task(columnFilters=[{**rule, 'values': ['X' * 257]}])
|
||||
|
||||
def test_contains_keywords_are_preserved_as_literal_or_values(self):
|
||||
rule = {'field': 'batchNumber', 'stages': ['black'], 'operator': 'contains',
|
||||
'values': [' 001', 'A|B', 'abC']}
|
||||
task = protocol_task(columnFilters=[rule])
|
||||
self.assertEqual(task['filters']['columnFilters'], [rule])
|
||||
for invalid in ([], [''], [' '], ['x' * 257], [1], ['one'] * 51):
|
||||
with self.subTest(invalid=invalid), self.assertRaises(TaskUnavailable):
|
||||
protocol_task(columnFilters=[{**rule, 'values': invalid}])
|
||||
|
||||
def test_protocol_presentation_enums_default_consistently_when_omitted_or_null(self):
|
||||
base = task_value(kind='metrics', dimensions=[], stages=['black'], fields=['rate'],
|
||||
period={'year': 2026, 'month': 3}, comparisonRequired=False,
|
||||
@@ -396,6 +405,10 @@ class SourceColumnProtocolTests(unittest.TestCase):
|
||||
self.assertIn('periodCoverage(available/complete,可省略或null', prompt)
|
||||
self.assertIn('freshQuery(bool)', prompt)
|
||||
self.assertIn('needsClarification(bool)', prompt)
|
||||
self.assertIn('in/not_in/contains/is_empty/not_empty', prompt)
|
||||
self.assertIn('contains关键字是子串而非完整候选值', prompt)
|
||||
self.assertEqual(model_call.call_args_list[0].kwargs['payload']['businessCatalog']['sourceColumnOperators'],
|
||||
['in', 'not_in', 'contains', 'is_empty', 'not_empty'])
|
||||
|
||||
def test_three_arbitrary_source_keys_keep_literal_values_and_stage_scopes(self):
|
||||
task = protocol_task()
|
||||
@@ -429,7 +442,7 @@ class SourceColumnProtocolTests(unittest.TestCase):
|
||||
def test_unauthorized_unknown_and_missing_stage_columns_fail_closed(self):
|
||||
for bad in ([{**RULES[0], 'field': 'notInDirectory'}],
|
||||
[{**RULES[0], 'field': 'blackOnlyCode', 'stages': ['bright']}],
|
||||
[{**RULES[0], 'operator': 'contains'}]):
|
||||
[{**RULES[0], 'operator': 'starts_with'}]):
|
||||
with self.subTest(bad=bad), self.assertRaises(TaskUnavailable):
|
||||
normalize_task(task_value(kind='metrics', dimensions=[], stages=['black'], fields=['rate'],
|
||||
period={'year': 2026}, columnFilters=bad), '筛选原表字段',
|
||||
@@ -529,6 +542,20 @@ class SourceColumnProtocolTests(unittest.TestCase):
|
||||
self.assertEqual(customer_lookup['filters']['columnFilters'], [
|
||||
{'field': 'dispatchOrder', 'stages': ['bright'], 'operator': 'not_empty'}])
|
||||
|
||||
def test_contains_keyword_skips_exact_candidate_value_validation(self):
|
||||
from nao_agent_task import _resolve_source_column_values
|
||||
rule = {'field': 'batchNumber', 'stages': ['black'], 'operator': 'contains',
|
||||
'values': ['001']}
|
||||
task = protocol_task(columnFilters=[rule])
|
||||
calls = []
|
||||
def resolver(**contract):
|
||||
calls.append(contract)
|
||||
raise AssertionError('contains is a substring, not a complete candidate value')
|
||||
result = _resolve_source_column_values(task, release_id=RELEASE, resolver=resolver)
|
||||
self.assertEqual(result, {'status': 'exact'})
|
||||
self.assertEqual(calls, [])
|
||||
self.assertEqual(task['filters']['columnFilters'], [rule])
|
||||
|
||||
def test_missing_literal_offers_same_scope_alternatives_without_substitution(self):
|
||||
from nao_agent_task import _resolve_source_column_values
|
||||
task = protocol_task(columnFilters=[RULES[0]])
|
||||
|
||||
Reference in New Issue
Block a user