优化:未分类连续维护与柏拉图预汇总,同步已发布修复
This commit is contained in:
@@ -8,6 +8,7 @@ import tempfile
|
||||
import unittest
|
||||
from pathlib import Path
|
||||
from urllib.parse import parse_qs, urlsplit
|
||||
from unittest.mock import patch
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(ROOT / "scripts"))
|
||||
@@ -17,6 +18,7 @@ from nao_quality_mcp import MCPServer, serve
|
||||
from nao_quality_tools import (
|
||||
QualityToolError,
|
||||
QualityTools,
|
||||
_private_rank_response_trace,
|
||||
normalize_filters,
|
||||
symmetric_stage_decomposition,
|
||||
tool_definition,
|
||||
@@ -219,6 +221,63 @@ class QualityToolsTests(unittest.TestCase):
|
||||
def tearDown(self):
|
||||
self.temp.cleanup()
|
||||
|
||||
def test_rank_failure_attaches_only_bounded_private_snapshot_shape(self):
|
||||
class MissingScopedStageApi(FakeApi):
|
||||
def call(inner, path, payload=None, method=None):
|
||||
result = super().call(path, payload, method)
|
||||
if urlsplit(path).path != "/api/metrics":
|
||||
return result
|
||||
if parse_qs(urlsplit(path).query).get("view") != ["product"]:
|
||||
return result
|
||||
row = FakeApi._product_row("private-product-key", "PRIVATE-PRODUCT", 0.83, 0.0)
|
||||
row["coverage"] = {"blackRows": 2, "brightRows": 0}
|
||||
row["bright"].pop("scrapWeight", None)
|
||||
result["rows"] = [row]
|
||||
result["context"]["rowCount"] = 1
|
||||
result["summary"]["black"]["scrapWeight"] = 0.83
|
||||
result["summary"]["bright"].pop("scrapWeight", None)
|
||||
result["summary"]["coverage"] = {"blackRows": 2, "brightRows": 0}
|
||||
# Monthly source counts can describe the published source month,
|
||||
# while the chosen product's scoped coverage is zero for bright.
|
||||
result["coverage"]["sourceMonths"] = [
|
||||
{"year": 2026, "month": 9, "blackRows": 2, "brightRows": 15}]
|
||||
result["coverage"]["missingStages"] = [
|
||||
{"year": 2026, "month": 9, "stage": "bright"}]
|
||||
result["protocolEvidence"] = {
|
||||
"queryId": "private-query-id", "responseHash": "b" * 64}
|
||||
return result
|
||||
|
||||
api = MissingScopedStageApi()
|
||||
tools = QualityTools(api_factory=lambda: api, evidence_dir=self.temp.name)
|
||||
arguments = {"mode": "rank", "releaseId": RELEASE,
|
||||
"period": {"year": 2026, "month": 9},
|
||||
"filters": {"product": "PRIVATE-PRODUCT"},
|
||||
"dimension": "product", "metric": "scrapWeight",
|
||||
"stage": None, "limit": 1}
|
||||
with patch("nao_weight_ranking.rank_response", side_effect=QualityToolError("trace fixture")):
|
||||
with self.assertRaisesRegex(QualityToolError, "trace fixture") as raised:
|
||||
tools.quality_data(arguments)
|
||||
trace = raised.exception._quality_private_rank_trace
|
||||
self.assertEqual(trace["queryId"], "private-query-id")
|
||||
self.assertEqual(trace["coverageSourceMonths"], [
|
||||
{"year": 2026, "month": 9, "blackRows": 2, "brightRows": 15,
|
||||
"countStates": {"blackRows": "known", "brightRows": "known"}}])
|
||||
self.assertEqual(trace["coverageMissingStages"], [
|
||||
{"year": 2026, "month": 9, "stage": "bright", "stageState": "known"}])
|
||||
self.assertEqual(trace["summaryCoverage"], {"blackRows": 2, "brightRows": 0})
|
||||
self.assertEqual(trace["summaryStages"]["black"]["values"]["scrapWeight"], "0.83")
|
||||
self.assertIsNone(trace["summaryStages"]["bright"]["values"].get("scrapWeight"))
|
||||
self.assertEqual(trace["rows"]["count"], 1)
|
||||
self.assertEqual(trace["rows"]["sample"][0]["coverage"], {"blackRows": 2, "brightRows": 0})
|
||||
self.assertEqual(trace["rows"]["sample"][0]["coverageStates"], {
|
||||
"blackRows": "known", "brightRows": "known"})
|
||||
self.assertNotIn("PRIVATE-PRODUCT", json.dumps(trace))
|
||||
self.assertNotIn("private-product-key", json.dumps(trace))
|
||||
unknown = _private_rank_response_trace({
|
||||
"coverage": {"sourceMonths": [{"year": 2026, "month": 9, "blackRows": 2}]}})
|
||||
self.assertIsNone(unknown["coverageSourceMonths"][0]["brightRows"])
|
||||
self.assertEqual(unknown["coverageSourceMonths"][0]["countStates"]["brightRows"], "missing")
|
||||
|
||||
def test_schema_has_one_tool_and_modes(self):
|
||||
definition = tool_definition()
|
||||
self.assertEqual(definition["name"], "quality_data")
|
||||
@@ -631,7 +690,7 @@ class QualityToolsTests(unittest.TestCase):
|
||||
"black": {"rate": 0.96, "totalWeight": 4, "qualifiedWeight": 3},
|
||||
"bright": {"rate": 0.99, "totalWeight": 0, "qualifiedWeight": 0},
|
||||
"coverage": {"blackRows": 3, "brightRows": 0}}
|
||||
self.assertIsNone(QualityTools._row_rate(row, None))
|
||||
self.assertAlmostEqual(float(QualityTools._row_rate(row, None)), 0.95)
|
||||
self.assertAlmostEqual(float(QualityTools._row_rate(row, "black")), 0.96)
|
||||
self.assertIsNone(QualityTools._row_rate(row, "bright"))
|
||||
self.assertIsNone(QualityTools._row_rate({**row, "coverage": None}, "black"))
|
||||
|
||||
Reference in New Issue
Block a user